Re: [PATCHv2 2/5] qemu_capabilities: Add support for nvme-ns bus capabilities
Generally patches adding a capability flag should only add the
capability flag. Thus you'll need to split this patch.
1) capability addition
- move it ahead to the beginning of the series (doing that will
allow you to do capability checks when adding the code instead
when adding the capability
- note the full flag name (QEMU_CAPS...) in the summary line of the
commit message
2) domain caps addition
- that ought to be done after the code addition is compelete, thus
after you add the XML schema bits and implementation
Okay, that's a very reasonable suggestion.
All of the above is suspicious. The test files were forgotten after we
dropped support for the qemu versions mentioned in them. How did you
modify these?
Interestingly there are more of the files for unsupported versions but
you didnt modify all of them.
Anyways I'll send a patch deleting those.
Modifying these test files is necessary to ensure the correctness of the unit
tests. The changes I made were based on the feedback from the unit tests :)
I've seen your patch that removes the deprecated XML—great job! I’ll rebase my patch
on top of it, but the other XML test files still need to be updated to include the nvme-ns
related content.