Re: [Libvir] [PATCH] deep copy dom structure

On Mon, Mar 31, 2008 at 08:49:12AM -0400, Daniel Veillard wrote: > On Mon, Mar 31, 2008 at 08:12:19AM -0400, Daniel Veillard wrote: > > On Mon, Mar 31, 2008 at 01:02:49PM +0100, Daniel P. Berrange wrote: > > > We should at the very least NULL-ify the dom/net fields in the Error > > > object associated with the Connection when we free the Domain/Network > > > object. > > > > agreed, very simple test but avoids dandling pointers. > > My patch for this. it's a bit more complex because we also keep a > global variable for the last variable, and that needed to be exported to > the hash module, it's still rather simple, Yes, ack from me too. I'm still going to deprecate these in the OCaml bindings, or maybe just change them so you can only do physical pointer comparisons. I just can't see a real life use for them ... You already know which call failed and from that what domain it was operating on, so except perhaps in the case of migration there is no new information here. Also I've not seen any libvirt program yet which does more than just print the error message and either abort or ignore it.