Re: [libvirt] [PATCH v3 2/3] libxl: advertise the support for VIR_TYPED_PARAM_STRING
Daniel P. Berrange wrote:
On Sat, Jul 13, 2013 at 02:27:10AM +0200, Dario Faggioli wrote:
> domainGetNumaParameters has a string typed parameter, hence it
> is necessary for the libxl driver to support this.
>
> This change implements the connectSupportsFeature hook for the
> libxl driver, advertising that VIR_DRV_FEATURE_TYPED_PARAM_STRING
> is supported.
>
> Signed-off-by: Dario Faggioli <dario.faggioli(a)citrix.com>
> Cc: Eric Blake <eblake(a)redhat.com>
> ---
> Changes from v1:
> * commit message improved, as requested during review;
> * added VIR_TYPED_PARAM_STRING_OKAY handling code in
> libxlDomainGetSchedulerParametersFlags();
> ---
> src/libxl/libxl_driver.c | 20 +++++++++++++++++++-
> 1 file changed, 19 insertions(+), 1 deletion(-)
>
ACK
I've pushed patches 2 and 3 now. Thanks Dario!
Regards,
Jim