Re: [libvirt] [jenkins-ci PATCH v2 6/8] guests: Enable PowerTools repo on CentOS 8 guests

On Wed, 2019-12-11 at 13:26 +0100, Fabiano Fidêncio wrote: > And this is the fixup for this one: > ``` > diff --git a/guests/lcitool b/guests/lcitool > index 059b789..c28c414 100755 > --- a/guests/lcitool > +++ b/guests/lcitool > @@ -749,13 +749,23 @@ class Application: > {package_manager} clean all -y > """).format(**varmap)) > elif os_name == "CentOS": > - sys.stdout.write(textwrap.dedent(""" > - RUN {package_manager} update -y && \\ > - {package_manager} install -y epel-release && \\ > - {package_manager} install -y {pkgs} && \\ > - {package_manager} autoremove -y && \\ > - {package_manager} clean all -y > - """).format(**varmap)) > + if os_version == "7": > + sys.stdout.write(textwrap.dedent(""" > + RUN {package_manager} update -y && \\ > + {package_manager} install -y epel-release && \\ > + {package_manager} install -y {pkgs} && \\ > + {package_manager} autoremove -y && \\ > + {package_manager} clean all -y > + """).format(**varmap)) > + else: > + sys.stdout.write(textwrap.dedent(""" > + RUN {package_manager} update -y && \\

> + {package_manager} config-manager > --set-enabled PowerTools -y && \\ > + {package_manager} install -y epel-release && \\ > + {package_manager} install -y {pkgs} && \\ > + {package_manager} autoremove -y && \\ > + {package_manager} clean all -y > + """).format(**varmap)) > else: > sys.stdout.write(textwrap.dedent(""" > RUN {package_manager} update -y && \\ > > ``` Also looks good!