Re: [libvirt] [PATCHv2 9/9] qemu: Move qemuParseKeywords(Free) to the monitor code

On Mon, 2019-06-17 at 14:55 +0200, Peter Krempa wrote: > The only user is now in qemu_monitor_json.c to re-parse the command line > format into keyvalue pairs for use in QMP command construction. > > Move and rename the functions. > > Signed-off-by: Peter Krempa <pkrempa(a)redhat.com&gt; > --- > po/POTFILES | 1 - > src/qemu/Makefile.inc.am | 2 - > src/qemu/qemu_monitor_json.c | 124 +++++++++++++++++++++++++++- > src/qemu/qemu_parse_command.c | 149 ---------------------------------- > src/qemu/qemu_parse_command.h | 37 --------- > 5 files changed, 120 insertions(+), 193 deletions(-) > delete mode 100644 src/qemu/qemu_parse_command.c > delete mode 100644 src/qemu/qemu_parse_command.h Reviewed-by: Andrea Bolognani <abologna(a)redhat.com&gt; As mentioned with the RFC, please don't push this right away but wait a week or so to give everyone a chance to voice their opinion about this removal.