Re: [PATCH] Added support for vendor and product for qemu ide-hd
On Sat, Jul 15, 2023 at 06:37:10PM +0200, Benedek Major wrote:
The XML-Schema specifies two tags vendor and product for the disk
type. But they only apply to the SCSI bus,
even though the QEMU driver ide-hd and ide-cd have support for the command line argument
-model.
The model corresponds to words 27-46 of the IDENTIFY PACKET DEVICE response from the
ATAPI spec.
Words 27-46 is a 40 Char space for the model number of the device. The model number is
built by
combining the vendor and the product fields with a single space as separator in the
middle.
Therefore I would say, that vendor and product pretty much correlate to the model field
in QEMU,
so the ide disk should also have the possibility of adding vendor and product to it.
Lets compare SCSI:
https://www.seagate.com/files/staticfiles/support/docs/manual/Interface%2...
[quote]
PRODUCT IDENTIFICATION
The PRODUCT IDENTIFICATION field contains sixteen bytes of left-aligned
ASCII data (see 5.4.2) defined by Seagate. Bytes 16 through 31 indicate
the drive model with 20h (space) used as a filler. The table below is
an example of drive test data returned by the drive. Bytes 16 and 17
will contain 53 54 for all drive models.
[/quote/
And ATARPI
https://people.freebsd.org/~imp/asiabsdcon2015/works/d2161r5-ATAATAPI_Com...
[quote]
A.11.7.4 MODEL NUMBER field
The MODEL NUMBER field contains the model number of the device. The
contents of the MODEL NUMBER field is an ATA string of forty bytes in
the format defined by 3.3.10. The device shall pad the string with
spaces (i.e., 20h), if necessary, to ensure that the string is the
proper length. The combination of the serial number (see A.11.7.2)
and the model number shall be unique for a given manufacturer.
The IDENTIFY DEVICE data contains a copy of the MODEL NUMBER field
(see IDENTIFY DEVICE data words 27..46 in table 45).
[/quote]
my interpretation is that the SCSI "product" field data is identical
to the ATAPI "model" field data.
AFAICT, ATAPI doesn't provide a way to expose a vendor in string
format. So I would say we accept 'product' for IDE, but reject
'vendor'
Having said that it would be interesting to know the results from
an IDENTIFY DEVICE / IDENTIFY PACKET DEVICE command on some *real*
hardware, as an illustration of what vendors actually did in
practice. I don't have access to any real hardware that still
uses SATA/IDE though.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|