Re: [libvirt] [libvirt-glib] Add gvir_domain_get_saved()
On Thu, Feb 16, 2012 at 10:16:11PM +0100, Christophe Fergeau wrote:
On Thu, Feb 16, 2012 at 09:51:34AM +0100, Christophe Fergeau wrote:
> On Thu, Feb 16, 2012 at 02:26:02AM +0200, Zeeshan Ali (Khattak) wrote:
> > + */
> > +gboolean gvir_domain_get_saved(GVirDomain *dom)
>
> The naming needs to be more explicit, libvirt will suspend the domain after
> a call to virDomainSave or virDomainManagedSave, the current name only
> checks for the latter state. I'd go for
> gvir_domain_has_managed_save_image();
I see this patch has been pushed to master with this part unchanged and no
discussion whatsoever on the list, what happened there?
Oh, I ACK'd his new patch, without noticing your message in this
thread.
I tend to agree with your suggestion to rename to
gvir_domain_has_managed_save_image()
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|