Re: [libvirt] [PATCH 1/5] Tighten libvirt's parsing of logging environment variables
On Fri, Jul 31, 2009 at 05:57:25PM -0400, Amy Griffis wrote:
Don't convert high priority levels to the debug level. Don't
parse
LIBVIRT_LOG_FILTERS and LIBVIRT_LOG_OUTPUTS when they're set to the
empty string. Warn when the user specifies an invalid value (empty
string remains a noop).
[...]
+++ b/src/logging.c
@@ -314,8 +314,10 @@ error:
* Returns 0 if successful, -1 in case of error.
*/
int virLogSetDefaultPriority(int priority) {
- if ((priority < VIR_LOG_DEBUG) || (priority > VIR_LOG_ERROR))
+ if ((priority < VIR_LOG_DEBUG) || (priority > VIR_LOG_ERROR)) {
+ VIR_WARN0(_("Ignoring invalid log level setting."));
Okay, applied, I just had to add src/logging.c to po/POTFILES.in as
it now includes translatable strings,
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/