Re: [libvirt] [PATCH] remote: remove the only use of LIBVIRTD_CONFIGURATION_FILE
On Thu, Jul 4, 2019 at 9:28 AM Peter Krempa <pkrempa(a)redhat.com> wrote:
On Thu, Jul 04, 2019 at 08:16:21 +0200, Fabiano Fidêncio wrote:
> 86fbce56f27e removed the constant, but didn't actually adjust the only
> place where the constant was used.
>
> Signed-off-by: Fabiano Fidêncio <fidencio(a)redhat.com>
> ---
> This patch fixes a build breakage.
>
> It's either this, or reverting 86fbce56f27e.
I've reverted it now sice the premise that the constant was unused is
wrong. A separate patch can e.g. squash this change and the removal of
the constant with a better justification perhaps. Obviously that will
need to go through review again to consider the merit of the
justification.
Fair enough! Thanks for taking care of this!