Re: [libvirt] [PATCH 2/4] virDomainInterfaceStats: Accept MAC address too

On 10/05/2017 10:18 AM, Michal Privoznik wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1497396 > > The other APIs accept both, ifname and MAC address. There's no > reason virDomainInterfaceStats can't do the same. > > Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com&gt; > --- > include/libvirt/libvirt-domain.h | 2 +- > src/driver-hypervisor.h | 2 +- > src/libvirt-domain.c | 15 ++++++++------- > src/libxl/libxl_driver.c | 8 ++++---- > src/lxc/lxc_driver.c | 8 ++++---- > src/openvz/openvz_driver.c | 8 ++++---- > src/qemu/qemu_driver.c | 10 +++++----- > src/remote/remote_protocol.x | 2 +- > src/remote_protocol-structs | 2 +- > src/test/test_driver.c | 11 ++++++----- > src/vz/vz_driver.c | 4 ++-- > src/vz/vz_sdk.c | 9 +++++++-- > src/xen/xen_driver.c | 11 +++++++++-- > tools/virsh.pod | 3 ++- > 14 files changed, 55 insertions(+), 40 deletions(-) > Order-wise - I think patch 4 should go after patch 1. That way this patch doesn't need all those error messages adjusted - they can just be removed when calling virDomainNetFind since it would already provide the message.

With ordering adjustment....

Reviewed-by: John Ferlan <jferlan(a)redhat.com&gt;