Re: [PATCH v14 04/15] qemu_command: Separate domain features building into a helper
On Wed, Jul 27, 2022 at 12:34:50 +0200, Michal Privoznik wrote:
The qemuBuildMachineCommandLine() function is needlessly long.
Separate out parts that generate arguments based on
domainDef->features[] into
qemuAppendDomainFeaturesMachineParam(). Unfortunately, expected
outputs for some qemuxml2argvdata cases needed to be updated
because the order in which features are generated is changed. But
there's no functional change.
Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
---
src/qemu/qemu_command.c | 154 ++++++++++--------
...-auto-efi-enrolled-keys.x86_64-latest.args | 2 +-
...-auto-efi-loader-secure.x86_64-latest.args | 2 +-
...firmware-auto-efi-nvram.x86_64-latest.args | 2 +-
...rmware-auto-efi-secboot.x86_64-latest.args | 2 +-
.../firmware-auto-efi.x86_64-latest.args | 2 +-
.../firmware-manual-efi-secure.args | 2 +-
.../machine-smm-off.x86_64-latest.args | 2 +-
.../machine-smm-on.x86_64-latest.args | 2 +-
.../qemuxml2argvdata/machine-vmport-opt.args | 2 +-
.../q35-virt-manager-basic.args | 2 +-
.../tseg-explicit-size.x86_64-latest.args | 2 +-
12 files changed, 95 insertions(+), 81 deletions(-)
Reviewed-by: Peter Krempa <pkrempa(a)redhat.com>