Re: [libvirt] [PATCH] Add a MAINTAINERS file to suggest reviewers for patches
On Tue, May 08, 2018 at 02:07:31PM +0100, Daniel P. Berrangé wrote:
Currently all patches are simply sent to the main libvirt development
mailing list. Sometimes individual developers are also CC'd but this is
typically the exception.
Libvirt does not follow a subsystem maintainer model, so there is no
notion of owners for the different areas of code, but there certainly
are people with high levels of expertize in specific areas.
We do not follow a subsystem maintainer model, so I think this approach
is out of place. If a maintainer feels like a change should be reviewed
by an expert, they already do that in my experience.
This patch thus proposes pulling in QEMU's get_maintainer.pl script and
creating MAINTAINERS file to list who the experts are for specific
areas. Combined with git-pubish, this will help ensure that patches are
brought to the attention of people with direct expertize.
Personally, I prefer not to be CC'd on libvirt patches. I follow the list.
And Jirka actually sets his Mail-Followup-To header to exclude
his address for all the patches and e-mail he sends.
For example:
$ git show b04629b62934caa8786e73c3db985672422fc662 | \
./build-aux/get_maintainer.pl
Jim Fehlig <jfehlig(a)suse.com> (maintainer:libxl)
libvir-list(a)redhat.com (open list:All patches)
Or
$ git show e7cb9c4e230c3c77e35e72334c261b5b0a2211c6 | \
./build-aux/get_maintainer.pl
Jiri Denemar <jdenemar(a)redhat.com> (maintainer:CPU modelling)
s/Denemar/Denemark/
libvir-list(a)redhat.com (open list:All patches)
Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com>
---
diff --git a/MAINTAINERS b/MAINTAINERS
new file mode 100644
index 0000000000..5756fd8b00
--- /dev/null
+++ b/MAINTAINERS
[...]
+
+Common code
+-----------
+
+CPU modelling
+M: Jiri Denemar <jdenemar(a)redhat.com>
s/Denemar/Denemark/
+S: Maintained
+F: src/cpu/
+
+Driver code
+-----------
+libxl
+M: Jim Fehlig <jfehlig(a)suse.com>
+S: Maintained
+F: src/libxl/
+F: tests/*libxl*
+
Jano
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)