Re: [PATCH 3/3] qemu/qemu_validate: Add capability check for the model igb
On 7/28/23 12:59, Peter Krempa wrote:
On Fri, Jul 28, 2023 at 16:09:38 +0800, Han Han wrote:
> Signed-off-by: Han Han <hhan(a)redhat.com>
> ---
> src/qemu/qemu_validate.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c
> index d5c2b2cd44..a5eb96c9b5 100644
> --- a/src/qemu/qemu_validate.c
> +++ b/src/qemu/qemu_validate.c
> @@ -1858,6 +1858,13 @@ qemuValidateDomainDeviceDefNetwork(const virDomainNetDef
*net,
> }
> }
>
> + if (net->model == VIR_DOMAIN_NET_MODEL_IGB &&
> + !virQEMUCapsGet(qemuCaps, QEMU_CAPS_IGB)) {
> + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
> + _("interface model igb is not supported with this QEMU
binary"));
> + return -1;
> + }
NACK, this was already discussed and is not needed:
https://listman.redhat.com/archives/libvir-list/2023-April/239345.html
Agreed. And thus patch 2/3 is not necessary either (unless we want to
report supported models in domcapabilities, but that's orthogonal - we
don't do that, yet. And until somebody wants that I'd like to keep it
that way.).
Michal