Re: [libvirt] [Qemu-devel] [RFC 1/3] qemu-agent: add guest-network-set-interface command

On 17/04/15 11:53, Chen Fan wrote: > Nowadays, qemu has supported physical NIC hotplug for high network > throughput. but it's in conflict with live migration feature, to keep > network connectivity, we could to create bond device interface which > provides a mechanism for enslaving multiple network interfaces into a > single "bond" interface. the active-backup mode can be used for an > automatic switch. so this patch is adding a guest-network-set-interface > command for creating bond device. so the management can easy to create > a bond device dynamically when guest running. > > Signed-off-by: Chen Fan <chen.fan.fnst(a)cn.fujitsu.com&gt; > ---

> @@ -588,6 +626,22 @@ > 'returns': ['GuestNetworkInterface'] } > ## > +# @guest-network-set-interface: > +# > +# Set guest network interface > +# > +# return: 0: call successful. > +# > +# -1: call failed. > +# > +# > +# Since: 2.3

> +## > +{ 'command': 'guest-network-set-interface', > + 'data' : {'interface': 'GuestNetworkInterface2' }, > + 'returns': 'int' } I thought that usage of built-in types as the returning value is deprecated. Lets return dictionary in guest-network-set (get)-interface