Re: [libvirt] [PATCH] cfg.mk: Simplify backslash alignment check

The use of [[:blank:]] was intended to cover tabs as well, but it couldn't possibly work in its current form, so the regex was tweaked in d09429abe826. With the original reason for using [[:blank:]] now gone, we can replace its usage with plain spaces. A comment about the purpose of the check is added as well. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com&gt; --- cfg.mk | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/cfg.mk b/cfg.mk index ea10ca19f..5cdeb7c65 100644 --- a/cfg.mk +++ b/cfg.mk @@ -1037,8 +1037,10 @@ sc_prohibit_http_urls: halt='Links must use https:// protocol' \ $(_sc_search_regexp) +# Alignment is usually achieved through spaces (at least two of them) +# or tabs (at least one of them) right before the trailing backslash sc_prohibit_backslash_alignment: - @prohibit='([[:blank:]][[:blank:]]| )\\$$' \ + @prohibit='( | )\\$$' \ in_vc_files='*\.([chx]|am|mk)$$' \ halt='Do not attempt to right-align backslashes' \ $(_sc_search_regexp) -- 2.14.3 -- libvir-list mailing list libvir-list(a)redhat.com https://www.redhat.com/mailman/listinfo/libvir-list