Re: [PATCH 1/2] Report first tried socket from remoteProbeSystemDriverFromSocket
On Tue, Nov 28, 2023 at 13:02:39 +0100, Martin Kletzander wrote:
This will improve an error message later on.
Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com>
---
src/remote/remote_daemon_dispatch.c | 2 +-
src/remote/remote_sockets.c | 11 +++++++++--
src/remote/remote_sockets.h | 2 +-
3 files changed, 11 insertions(+), 4 deletions(-)
[...]
diff --git a/src/remote/remote_sockets.c
b/src/remote/remote_sockets.c
index 4ab3d72933e2..c21970cd31e7 100644
--- a/src/remote/remote_sockets.c
+++ b/src/remote/remote_sockets.c
[...]
@@ -243,6 +246,9 @@ remoteProbeSystemDriverFromSocket(bool readonly,
char **driver)
return 0;
}
+ if (first_socket && !*first_socket)
+ *first_socket = g_steal_pointer(&sockname);
You steal 'sockname' here ...
+
VIR_DEBUG("Missing sock %s for driver %s", sockname, drivers[i]);
... and here it's still used.
For making the code future proof, it'll be most likely better to simply
copy the string instead of rearranging it to be able to steal it.
}
With the bug above addressed:
Reviewed-by: Peter Krempa <pkrempa(a)redhat.com>