Re: [PATCH V4 0/5] Introduce Advanced Watch Dog module

On 2020/2/11 下午4:58, Zhang, Chen wrote: >> -----Original Message----- >> From: Jason Wang&lt;jasowang(a)redhat.com&gt; >> Sent: Monday, January 20, 2020 10:57 AM >> To: Zhang, Chen&lt;chen.zhang(a)intel.com&gt;; Paolo Bonzini >> <pbonzini(a)redhat.com>; Philippe Mathieu-Daudé&lt;philmd(a)redhat.com&gt;; >> qemu-dev&lt;qemu-devel(a)nongnu.org&gt; >> Cc: Zhang Chen&lt;zhangckid(a)gmail.com&gt; >> Subject: Re: [PATCH V4 0/5] Introduce Advanced Watch Dog module >> >> >> On 2020/1/19 下午5:10, Zhang, Chen wrote: >>> Hi~ >>> >>> Anyone have comments about this module? >> Hi Chen: >> >> I will take a look at this series. > Sorry for slow reply due to CNY and extend leave. > OK, waiting your comments~ Thanks~ > >> Two general questions: >> >> - if it can detect more than network stall, it should not belong to /net > This module use network connection status to detect all the issue(Host to Guest/Host to Host/Host to Admin...). > The target is more than network but all use network way. So it is looks a tricky problem. Ok. >> - need to convince libvirt guys for this proposal, since usually it's the duty of >> upper layer instead of qemu itself >> > Yes, It looks a upper layer responsibility, but In the cover latter I have explained the reason why we need this in Qemu. > try to make this module as simple as possible. This module give upper layer software a new way to connect/monitoring Qemu. > And due to all the COLO code implement in Qemu side, Many customer want to use this FT solution without other dependencies, > it is very easy to integrated to real product. > > Thanks > Zhang Chen I would like to hear from libvirt about such design.

Thanks