Re: [libvirt] [PATCHv2 00/16] LXC network configuration support
Hi Richard,
On Tue, 2014-08-26 at 22:32 +0200, Richard Weinberger wrote:
On Tue, Aug 26, 2014 at 3:20 PM, Cédric Bosdonnat
<cbosdonnat(a)suse.com> wrote:
> Hi all,
>
> Here is the whole series resent with a major addition: the functions
> used to set the IP and add a route now use libnl when possible. The idea
> behind this is to avoid requiring iproute2 or ifconfig installed in the
> container rootfs.
What about my comments on v1?
Entering only the network NS would have a larger impact on the container
initialization code and we would still need to have iproute2/ifconfig
installed in the container... and nothing guarantees that will be true.
OTOH, we are pretty sure we'll have rtnetlink support in the kernel.
And if for some reason we don't have libnl at build time, the old code
using iproute2/ifconfig will still be used.
I went with a libnl implementation based on Laine's advise on IRC.
--
Cedric
> Otherwise nothing changed since v1.
>
> Cédric Bosdonnat (16):
> Forgot to cleanup ifname_guest* in domain network def parsing
> Domain conf: allow more than one IP address for net devices
> LXC: set IP addresses to veth devices in the container
> lxc conf2xml: convert IP addresses
> Allow network capabilities hostdev to configure IP addresses
> lxc conf2xml: convert ip addresses for hostdev NICs
> Domain network devices can now have a <gateway> element
> lxc conf2xml: convert lxc.network.ipv[46].gateway
> LXC: use the new net devices gateway definition
> LXC: honour network devices link state
> Wrong place for virDomainNetIpsFormat
> virNetDevSetIPv4Address: libnl implementation
> Renamed virNetDevSetIPv4Address to virNetDevSetIPAddress
> virNetDevAddRoute: implementation using netlink
> virNetDevClearIPv4Address: netlink implementation
> Renamed virNetDevClearIPv4Address to virNetDevClearIPAddress
>
> docs/formatdomain.html.in | 39 +++
> docs/schemas/domaincommon.rng | 55 +++-
> src/conf/domain_conf.c | 214 +++++++++++++--
> src/conf/domain_conf.h | 22 +-
> src/libvirt_private.syms | 7 +-
> src/lxc/lxc_container.c | 74 ++++-
> src/lxc/lxc_native.c | 173 ++++++++----
> src/network/bridge_driver.c | 4 +-
> src/openvz/openvz_conf.c | 2 +-
> src/openvz/openvz_driver.c | 6 +-
> src/qemu/qemu_driver.c | 25 +-
> src/qemu/qemu_hotplug.c | 6 +-
> src/uml/uml_conf.c | 2 +-
> src/util/virnetdev.c | 305 ++++++++++++++++++---
> src/util/virnetdev.h | 12 +-
> src/util/virnetlink.c | 38 +++
> src/util/virnetlink.h | 2 +
> src/vbox/vbox_common.c | 3 +-
> src/xenconfig/xen_common.c | 15 +-
> src/xenconfig/xen_sxpr.c | 12 +-
> .../lxcconf2xmldata/lxcconf2xml-physnetwork.config | 4 +
> tests/lxcconf2xmldata/lxcconf2xml-physnetwork.xml | 3 +
> tests/lxcconf2xmldata/lxcconf2xml-simple.config | 4 +
> tests/lxcconf2xmldata/lxcconf2xml-simple.xml | 3 +
> tests/lxcxml2xmldata/lxc-hostdev.xml | 3 +
> tests/lxcxml2xmldata/lxc-idmap.xml | 3 +
> 26 files changed, 880 insertions(+), 156 deletions(-)
>
> --
> 1.8.4.5
>
> --
> libvir-list mailing list
> libvir-list(a)redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list