Re: [PATCH] virsh: Fix logic wrt to --current flag in cmdSetmem
On 5/18/21 3:02 PM, Ján Tomko wrote:
On a Tuesday in 2021, Michal Privoznik wrote:
> In my commit of v7.1.0-rc1~376 I've simplified the logic of
> handling @flags. My assumption back then was that calling
> virDomainSetMemory() is equivalent to
> virDomainSetMemoryFlags(flags = 0). But that is not the case,
> because it is equivalent to virDomainSetMemoryFlags(flags =
> VIR_DOMAIN_AFFECT_LIVE). Fix the condition that calls the old
> API.
>
> Fixes: b5e267e8c59a257652f88d034cb1e0ce1ed4b58a
before that commit, if the user did not specify any of:
config, live, current
we used the old API.
After this change, the new API will be used for those cases.
Will it? I think that with just --live @flags will be
VIR_DOMAIN_AFFECT_CURRENT | VIR_DOMAIN_AFFECT_LIVE, which is effectively
just VIR_DOMAIN_AFFECT_LIVE which means that the old API is used.
Am I missing something?
Michal