Re: [libvirt] [PATCH 12/12] apparmor, virt-aa-helper: Allow access to /sys/bus/usb/devices

On Tue, 2017-12-19 at 16:03 +0100, Christian Ehrhardt wrote: > examples/apparmor/usr.lib.libvirt.virt-aa-helper | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/examples/apparmor/usr.lib.libvirt.virt-aa-helper > b/examples/apparmor/usr.lib.libvirt.virt-aa-helper > index d63c844..de92291 100644 > --- a/examples/apparmor/usr.lib.libvirt.virt-aa-helper > +++ b/examples/apparmor/usr.lib.libvirt.virt-aa-helper > @@ -22,6 +22,8 @@ profile virt-aa-helper > /usr/{lib,lib64}/libvirt/virt-aa-helper { > # for hostdev > /sys/devices/ r, > /sys/devices/** r, > + /sys/bus/usb/devices/ r, > + /sys/bus/usb/devices/** r, > deny /dev/sd* r, > deny /dev/vd* r, > deny /dev/dm-* r,

Note that only the first rule is needed since /sys/bus/usb/devices/ is a symlink farm (at least these days). AppArmor resolves symlinks before applying mediation so the glob rule won't ever match anything.

+1 for first rule.