On 09/22/2011 09:35 AM, Eric Blake wrote:
On 09/21/2011 07:15 PM, ajia(a)redhat.com wrote:
> From: Alex Jia<ajia(a)redhat.com>
>
> * src/locking/lock_driver_sanlock.c: remove redundant codes in
> error_unlink
> label from virLockManagerSanlockSetupLockspace, in fact, the codes
> make
> sure 'path' is non-null before getting to error_unlink label, so
> 'if (path)'
> is redundant, removing it in here and will also silence coverity.
I'd rather go with my more comprehensive patch, since it also fixes a
mem leak:
https://www.redhat.com/archives/libvir-list/2011-September/msg00865.html
Agree, my patch is incomplete, it's okay for me.
Thanks,
Alex