Re: [libvirt] PATCH: Test the QEMU argv -> XML convertor
On Tue, May 19, 2009 at 06:47:00PM +0100, Daniel P. Berrange wrote:
This patch adds a test case which validates the argv -> XML
convertor for QEMU. This re-uses the existing XML data files
from the XML -> argv test. This has a few complications
though because we can't roundtrip all the data. So I have a
couple really seriously evil regexes which splice out the
XML lines we know won't match - name, uuid, memory and
disk sharing modes. This isn't ideal, but I figure it is
better todo this and get coverage over 90% of the code, than
to have no test coverage. Thanks to Cole for this testsuite
suggestion
yeah, I will drop my XML pedantic POV for a moment, for the
sake of better testing it's better to one day get an false error
due to XML formatting change than drop the test :-)
ACK, thanks !
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/