Re: [libvirt] [PATCH] RFC: qemu: add vmcoreinfo support

Hi ----- Original Message ----- > On Mon, Nov 06, 2017 at 01:09:09PM +0100, marcandre.lureau(a)redhat.com wrote: > >From: Marc-André Lureau <marcandre.lureau(a)redhat.com&gt; > > > >Starting from qemu 2.11, the `-device vmcoreinfo` will create a fw_cfg > >entry for a guest to store dump details, necessary to process kernel > >dump with KASLR enabled and providing additional kernel details. > > > >Since the device is a singleton and shouldn't use additional hardware > >resources, I decided to map this to a <feature> element in the libvirt > >domain XML. Feel free to argue and decide if it is better to have it > >under <devices> instead. > > > > So is this similar to -fw_cfg name=etc/vmcoreinfo,file=X but in this case it > is > not backed by a file, but collected by QEMU itself? correct

> > I'm OK with this being a feature. Should I split the commit or can I resubmit like this without RFC?