Re: [libvirt] [dbus PATCH] build: convert to Meson/Ninja build system
On Wed, Sep 18, 2019 at 9:57 PM Ján Tomko <jtomko(a)redhat.com> wrote:
On Wed, Sep 18, 2019 at 05:40:06PM +0200, Fabiano Fidêncio wrote:
>On Wed, Sep 18, 2019 at 1:22 AM Fabiano Fidêncio <fidencio(a)redhat.com> wrote:
>>
>> On Tue, Sep 17, 2019 at 8:17 PM Pavel Hrdina <phrdina(a)redhat.com> wrote:
>> >
>> > On Tue, Sep 17, 2019 at 06:53:30PM +0200, Fabiano Fidêncio wrote:
>> > > On Tue, Sep 17, 2019 at 5:22 PM Pavel Hrdina
<phrdina(a)redhat.com> wrote:
>> > This is an intentional change to run syntax-check tests for dist target
>> > as well, but it might be possible to configure it somehow. Anyway, I
>> > would rather prefer to run syntax-check when running ninja dist than
>> > having it as a separate target.
>>
>> osinfo-db-tools has it, libosinfo has it, libvirt-jenkins-ci uses it.
>> This is a pattern already being used and here I have a strong
>> preference for not changing the pattern if we can easily adapt to it.
>
>Just for the record, we had a face-to-face discussion about this and
Can you record the reasoning as well?
A few topics were brought up:
- It's closer to what different projects using meson are doing
(systemd was the example used);
- It runs on `ninja dist` without having to run an additional command
(`ninja syntax-check`);
- If the test is named 'syntax-check', the test can still be run as
`meson test syntax-check`;
Everything else is just about personal preference. And talking about
personal preference, I'd rather keep the syntax-check target, it looks
cleaner to me ... however, my personal preference is far from counting
something on "libvirt land" and I'm okay on adapting osinfo related
projects to whatever is decided here.
There are projects, though, which do not have any tests (gtk-vnc, for
example) and those will have to add a single test case to run
syntax-check in order to adapt to this decision. Up to the maintainers
to decide what to do ... but consistence, IMHO, is important.
Jano
>agreement was to:
>- Do not introduce the `syntax-check` target for libvirt-dbus;
>- Patch osinfo-db-tools, (gtk-vnc,)? and libosinfo (depending on when
>the code will be reviewed / merged) to remove the syntax-check target;
>- Patch libvirt-jenkins-ci to remove the syntax-check target from the
>meson jobs;
>
>Best Regards,
>--
>Fabiano Fidêncio
>
>--
>libvir-list mailing list
>libvir-list(a)redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list