On Mon, Aug 07, 2006 at 05:35:18PM -0400, Daniel Veillard wrote:
On Mon, Aug 07, 2006 at 10:12:02PM +0100, Daniel P. Berrange wrote:
So how should we go about implementing this ? Can we have code in xend_internal.c that talks to XenStore to extract the VNC port ?
yes, one must check first that the xenstore connection is open (or the read-only one in the proxy this is a TODO it wasn't needed until now) and do the cross call. I think there is little to gain there trying to reach absolute purity within the
Yeah, that was pretty much what I was expecting.
This is the same problem we so far prevented me adding the path to the serial console Psuedo-TTY to the XML for a domain. I'd rather like to have this in 0.1.4 release of libvirt too, so any suggestions on how to approach implementation when some of the data for the XML needs to come from XS ?
I would make a wrapper function for the 2 special xs_read calls, to only export relatively high level interface from xs_internal.h for example
int xenStoreDomainVncPort(virDomainPtr domain);
returning -1 in case of error. Similar for the TTY.
Make sense ?
Yeah sounds resonable to me. I'll take a crack at implementing these two additions to the XML doc and post a patch for review when I have something reasonable working. Regards, Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|