Re: [PATCH V2 2/2] qemu: Add support for 'image_format' typed parameter
On Tue, Feb 25, 2025 at 11:34:24AM -0700, Jim Fehlig wrote:
On 2/25/25 07:43, Daniel P. Berrangé wrote:
> On Thu, Feb 20, 2025 at 05:23:54PM -0700, Jim Fehlig via Devel wrote:
> > Add support for the 'image_format' typed parameter in
virDomainSaveParams.
> > The parameter overrides the 'save_image_format' setting in qemu.conf.
> >
> > Signed-off-by: Jim Fehlig <jfehlig(a)suse.com>
> > ---
> > src/qemu/qemu_driver.c | 20 ++++++++++++++++----
> > 1 file changed, 16 insertions(+), 4 deletions(-)
>
> Reviewed-by: Daniel P. Berrangé <berrange(a)redhat.com>
Hi Daniel,
Thanks for reviewing this and the related series! I suppose it's too late to
push these for 11.1.0? If so, I'll change the 'Since:' to 11.2.0 in patch1
and push after the release.
I could kinda argue for the other series being a bugfix, but since its
motivation is mostly to assist this series, we might as well merge both
together after the release.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|