Re: [libvirt] [PATCH 1/2] qemu: Support SPICE listen over unix socket

On 03/22/2016 04:13 AM, Pavel Hrdina wrote: > On Mon, Mar 21, 2016 at 07:30:44PM -0400, Cole Robinson wrote: >> Add support for SPICE listen over unix socket. This has been in qemu >> since v2.3. The XML is: >> >> <spice socket='/path/to/socket'/> >> >> Which matches support for VNC listen over unix socket. >> >> https://bugzilla.redhat.com/show_bug.cgi?id=1151761 >> --- >> +++ b/tests/qemuxml2argvdata/qemuxml2argv-graphics-spice-unix.xml >> @@ -0,0 +1,27 @@ >> +<domain type='qemu'> >> + <name>QEMUGuest1</name> >> + <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid> >> + <memory unit='KiB'>219136</memory> >> + <currentMemory unit='KiB'>219136</currentMemory> >> + <vcpu placement='static'>1</vcpu> >> + <os> >> + <type arch='i686' machine='pc'>hvm</type> >> + <boot dev='hd'/> >> + </os> >> + <clock offset='utc'/> >> + <on_poweroff>destroy</on_poweroff> >> + <on_reboot>restart</on_reboot> >> + <on_crash>destroy</on_crash> >> + <devices> >> + <emulator>/usr/bin/qemu</emulator> >> + <controller type='usb' model='none' index='0'/> >> + <controller type='pci' index='0' model='pci-root'/> >> + <input type='mouse' bus='ps2'/> >> + <input type='keyboard' bus='ps2'/> >> + <graphics type='spice' socket='/tmp/spice.socket'/> > > This is an old way to specify listen type. It would be better to add a new > <listen type='socket' socket='/tmp/spice.socket'/>. Actually I'm working on > this support and I have my patches almost finished but they depends on this > patch series: > > https://www.redhat.com/archives/libvir-list/2016-March/msg00631.html > I'll give that a review > You can see my progress there: > > https://github.com/Antique/libvirt/tree/spice-unix-socket > Okay I'll defer to your patches. Check my cover letter for more ideas if you're motivated, I didn't check to see if your patches fixed all those issues.