Re: [libvirt] [PATCH 05/12] libvirt_private: add 4 new func in libvirt_private.syms
On 01/06/2015 04:11 PM, Peter Krempa wrote:
On 01/06/15 09:10, lhuang wrote:
> On 01/05/2015 10:48 PM, Peter Krempa wrote:
>> On 01/03/15 06:06, Luyao Huang wrote:
>>> Signed-off-by: Luyao Huang <lhuang(a)redhat.com>
>>> ---
>>> src/libvirt_private.syms | 5 +++++
>>> 1 file changed, 5 insertions(+)
>>>
>>> diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
>>> index aa776b4..deab4cf 100644
>>> --- a/src/libvirt_private.syms
>>> +++ b/src/libvirt_private.syms
>>> @@ -375,7 +375,12 @@ virDomainPMSuspendedReasonTypeToString;
>>> virDomainRedirdevBusTypeFromString;
>>> virDomainRedirdevBusTypeToString;
>>> virDomainRNGBackendTypeToString;
>>> +virDomainRNGDefFree;
>>> +virDomainRNGEquals;
>>> +virDomainRNGFind;
>>> +virDomainRNGInsert;
>>> virDomainRNGModelTypeToString;
>>> +virDomainRNGRemove;
>>> virDomainRunningReasonTypeFromString;
>>> virDomainRunningReasonTypeToString;
>>> virDomainSaveConfig;
>>>
>> These should be in the patches that add the individual functions.
> Okay, i will move virDomainRNGEquals, virDomainRNGFind,
> virDomainRNGEquals, virDomainRNGRemove to other
> patchs, and leave virDomainRNGDefFree in this patch.
If a function exists already, then add the symbol export to the patch
that uses it in a place that requires the symbol being exported.
Got it, thanks
your advise.
> Thanks for review.
>> Peter
>>
Peter
Luyao