Re: [libvirt] [PATCH 5/5] qemu: Fix condition for checking vcpu when pinning vcpus

On 04/07/2015 02:50 PM, Peter Krempa wrote: > Previously we checked that the vcpu we are trying to set is in range of > the number of threads presented by qemu. The problem is that if the VM > is offline the count is 0. Since the condition subtracted 1 from the > count the number would overflow and the check would never trigger. > > Change the condition for more sensible ones with specific error > messages. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1208434 > --- > src/qemu/qemu_driver.c | 13 ++++++++++--- > 1 file changed, 10 insertions(+), 3 deletions(-) > ah yes, I remember pondering this code while working through the IOThreads pinning code. ACK

John BTW: As with the add/del IOThreads code - this is yet another one of those places where using [n]vcpupids caused me to make a [n]iothreadpids