Re: [libvirt] [PATCH] openvz: swap <source bridge=...> with <target dev=...>

My point of view is to use small count common methods to manipulate config parameters. That is don't use array of differend methods for different types of data. In current case we can transform format to be used common functions. For example: if we will use format #BRIDGE-ifname=<> we can drop openvzGetDefinedBridge and use one existing method openvzReadConfigParam(veid, "#BRIDGE-ifname", value, sizeof(value)); openvzSetDefinedBridge can be simplified if create openvzAppendParamToConfig openvzSetDefinedBridge() { openvzReadConfigParam() if not found openvzAppendParamToConfig() return } May be you will found better way. + case VIR_DOMAIN_NET_TYPE_BRIDGE: + veth = net->ifname; + bridge = net->data.bridge.brname; + if (rc = brAddInterface(brctl, bridge, veth)) { + openvzError(conn, VIR_ERR_INTERNAL_ERROR, + _("failed to add %s device to %s: %s"), + veth, bridge, strerror(rc)); + goto exit; + } + break; It will be good to check veth & bridge for NULL. Potentially it may happens when config is broken. @@ -602,6 +713,12 @@ openvzDomainCreate(virDomainPtr dom) return -1; } + if (openvzSetBridges(dom->conn, vm->def->name, vm->def->nets) < 0) { + openvzError(dom->conn, VIR_ERR_INTERNAL_ERROR, + _("Could not configure bridges")); + return -1; + } + Also, we need to set bridges in openvzDomainReboot method. > > There's no need to store veth101.0, veth101.2 - they are automatically > generated & not intended to be stable across restarts. It is merely > > No, there is. They are generated only once --- when VE container is created. > After that they are stored in the config file. > > neccessary to persist the name of the bridge (or virtual network) to > which they are attached, and the MAC address. > > Daniel > -- > |: Red Hat, Engineering, London -o- > http://people.redhat.com/berrange/ :| > |: http://libvirt.org -o- http://virt-manager.org -o- > http://ovirt.org :| > |: http://autobuild.org -o- > http://search.cpan.org/~danberr/ <http://search.cpan.org/%7Edanberr/> :| > |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 > 7D3B 9505 :| > > ------------------------------------------------------------------------ > > -- > Libvir-list mailing list > Libvir-list(a)redhat.com > https://www.redhat.com/mailman/listinfo/libvir-list -- Evgeniy Sokolov Parallels