Re: [libvirt PATCH 7/9] virsh: Add "validate" argument to [hypervisor-]cpu-compare
On Mon, Sep 21, 2020 at 15:07:30 +0200, Tim Wiederhake wrote:
Again the summary is misleading and empty commit message doesn't help.
This patch also adds a flag to the public API which is an important
change rather than just modifying virsh.
The summary should mention the public API change rather than the virsh
bit.
Signed-off-by: Tim Wiederhake <twiederh(a)redhat.com>
---
include/libvirt/libvirt-host.h | 1 +
src/bhyve/bhyve_driver.c | 7 +++++--
src/libxl/libxl_driver.c | 7 +++++--
src/qemu/qemu_driver.c | 18 +++++++++++++-----
tools/virsh-host.c | 14 ++++++++++++++
5 files changed, 38 insertions(+), 9 deletions(-)
[...]
diff --git a/tools/virsh-host.c b/tools/virsh-host.c
index 722c47958b..80edfae16c 100644
--- a/tools/virsh-host.c
+++ b/tools/virsh-host.c
@@ -1214,6 +1214,10 @@ static const vshCmdOptDef opts_cpu_compare[] = {
.type = VSH_OT_BOOL,
.help = N_("report error if CPUs are incompatible")
},
+ {.name = "validate",
+ .type = VSH_OT_BOOL,
+ .help = N_("enable XML file validation")
+ },
{.name = NULL}
};
Missing addition to virsh man page
[...]
@@ -1636,6 +1643,10 @@ static const vshCmdOptDef
opts_hypervisor_cpu_compare[] = {
.type = VSH_OT_BOOL,
.help = N_("report error if CPUs are incompatible")
},
+ {.name = "validate",
+ .type = VSH_OT_BOOL,
+ .help = N_("enable XML file validation")
+ },
{.name = NULL}
};
Missing addition to virsh man page