Re: [Libvir] libvirt.c: avoid a double-free upon do_open failure

With a contrived example using more than 20 (the max permitted by the testing framework) domains, I got a double-free error:

here's one way to fix it: diff --git a/src/libvirt.c b/src/libvirt.c index defadc1..c19565f 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -615,7 +615,6 @@ do_open (const char *name, return ret; failed: - free (ret->name); if (ret->driver) ret->driver->close (ret); if (uri) xmlFreeURI(uri); virUnrefConnect(ret); At first, rather than removing the offending free, I inserted this line just after it: ret->name = NULL; which avoids leaking ->name even if some driver-specific close function fails to clean up properly. But IMHO if such a function doesn't clean up properly then *it* should be fixed, not all callers.