Re: [libvirt] PATCH: Fix misc memory alloc/free/usage bugs

On Mon, Mar 30, 2009 at 11:41:20PM +0900, Ryota Ozaki wrote: > Hi Daniel, > > On Mon, Mar 30, 2009 at 10:39 PM, Daniel P. Berrange > <berrange(a)redhat.com&gt; wrote: > > A few more small bugs > > > >  * src/node_device.c: Don't strdup() a NULL device parent > >  * src/qemu_conf.c: Don't try to run access() on a NULL binary path > >  * src/security_selinux.c Make sure result from readlink() is NULL > >   terminated > >  * src/storage_conf.c: DOn't free 'mode' while it is still used Patch looks fine, with the exception [...] > > +++ b/src/security_selinux.c    Mon Mar 30 14:37:45 2009 +0100 > > @@ -303,11 +303,13 @@ SELinuxRestoreSecurityImageLabel(virConn > >         return -1; > > > >     if (S_ISLNK(buf.st_mode)) { > > +        int n; > >         if (VIR_ALLOC_N(newpath, buf.st_size + 1) < 0) > >             return -1; > > > > -        if (readlink(path, newpath, buf.st_size) < 0) > > +        if ((n =readlink(path, newpath, buf.st_size)) < 0) > >             goto err; > > +        buf.st_size[n] = '\0'; > newpath[n] = '\0'; > > correct? Yup, I doubt it would compile otherwise :-)