Re: [libvirt] [PATCH 04/10] Add support for -device with audio devices

On Tue, Dec 15, 2009 at 03:14:44PM +0000, Daniel P. Berrange wrote: > The current syntax for audio devices is a horrible multiplexed > arg > > -soundhw sb16,pcspk,ac97 > > The new syntax is > > -device sb16 > -device ac97 > --- > src/qemu/qemu_conf.c | 72 +++++++++++++++++++++++++++++++++++++------------ > 1 files changed, 54 insertions(+), 18 deletions(-) > > diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c > index 79b7b00..8c44a93 100644 > --- a/src/qemu/qemu_conf.c > +++ b/src/qemu/qemu_conf.c > @@ -1538,6 +1538,28 @@ qemuBuildHostNetStr(virConnectPtr conn, > return 0; > } > > +static int > +qemuBuildSoundDevStr(virConnectPtr conn, > + virDomainSoundDefPtr sound, > + char **str) > +{ > + const char *model = virDomainSoundModelTypeToString(sound->model); > + > + if (STREQ(model, "es1370")) > + model = "ES1370"; > + else if (STREQ(model, "ac97")) > + model = "AC97"; I'm not sure I understand why those 2 strings need to be upper-cased