Re: [libvirt PATCH] qemu: remove default audio backend for migratable XML
On 7/8/21 12:01 PM, Daniel P. Berrangé wrote:
When seeing a guest with a sound device, and no audio backend, we
automatically add an audio backend XML element based on the historical
QEMU driver behaviour. Unfortunately when we live migrate back to an
old libvirt, it may not understand the audio driver type we configured.
We thus need to strip the default audio backend when migrating.
Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com>
---
src/libvirt_private.syms | 1 +
src/qemu/qemu_domain.c | 128 ++++++++++++++++++++++++++++++---------
2 files changed, 101 insertions(+), 28 deletions(-)
You'll need to squash this in:
diff --git i/tests/qemumigrationcookiexmldata/full-xml2xml-out.xml
w/tests/qemumigrationcookiexmldata/full-xml2xml-out.xml
index 013cfb1eb2..a07dd1f147 100644
--- i/tests/qemumigrationcookiexmldata/full-xml2xml-out.xml
+++ w/tests/qemumigrationcookiexmldata/full-xml2xml-out.xml
@@ -142,7 +142,6 @@
<sound model='ich6'>
<address type='pci' domain='0x0000' bus='0x00'
slot='0x04' function='0x0'/>
</sound>
- <audio id='1' type='spice'/>
<video>
<model type='qxl' ram='65536' vram='65536'
vgamem='16384' heads='1' primary='yes'/>
<address type='pci' domain='0x0000' bus='0x00'
slot='0x02' function='0x0'/>
But of course qemumigrationcookietest fails if you run just one specific test case,
because it depends on previous test cases to prepare domain object. Le sigh.
Reviewed-by: Michal Privoznik <mprivozn(a)redhat.com>
Michal