Re: [libvirt] [PATCH] Define remote wire protocol & impls for virDomainQemuAttach

On 07/08/2011 06:20 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" <berrange(a)redhat.com&gt; > > This tweaks the RPC generator to cope with some naming > conventions used for the QEMU specific APIs > > * daemon/remote.c: Server side dispatcher > * src/remote/remote_driver.c: Client side dispatcher > * src/remote/qemu_protocol.x: Wire protocol definition > * src/rpc/gendispatch.pl: Use '$structprefix' in method > names, fix QEMU flags and fix dispatcher method names > --- > src/remote/qemu_protocol.x | 13 ++++++++++++- > src/remote/remote_driver.c | 1 + > src/rpc/gendispatch.pl | 11 +++++++++-- > 3 files changed, 22 insertions(+), 3 deletions(-) Hmm. We have src/remote_protocol-structs to catch any incompatible on-the-wire changes to remote_protocol.x, but nothing to track changes to qemu_protocol.x. Is this something that needs fixing to help us avoid unintended wire breakage?