Re: [libvirt] [PATCH] Imprint all logs with version + package build information

[adding bug-gnulib] On 01/27/2011 11:21 AM, Daniel P. Berrange wrote: I like it. Let's have some cross-project compatibility (to avoid confusion or subtle typos when using the same option already in use elsewhere). Many GNU projects already have the following configure options: --with-packager String identifying the packager of this software --with-packager-version Packager-specific version information --with-packager-bug-reports Packager info for bug reports (URL/e-mail/...) and in fact, they get that straight out of gnulib, via the version-etc module (unfortunately LGPLv3+ at the moment) - let me see if I can get that improved, so we can reap the benefits of shared code, before I review a slightly different implementation for libvirt. But part of the issue is that the current version-etc module, in addition to providing the nice .m4 file for defining additional PACKAGER variables in the source code, also provides the version_etc() function which is hardcoded to output a GPLv3+ version string (oops - why is the module LGPLv3+ if it outputs GPLv3+?). Gnulib already has version-etc-fsf separate from version-etc for easy exclusion of an FSF copyright holder, so what is still missing is an easy way to override the default license output when using version_etc(). Maybe by moving the default GPLv3+ out of version-etc.c and into version-etc-fsf.c. -- Eric Blake eblake(a)redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org