Re: [libvirt] [PATCH 13/14] secret: Alter configFile/base64File mgmt
On 04/25/2017 07:45 AM, Pavel Hrdina wrote:
On Mon, Apr 24, 2017 at 02:00:22PM -0400, John Ferlan wrote:
> Rather than being generated during virSecretObjListAdd, generate the file
> paths in each of the callers and then copy those paths into the object
> rather than stealing their pointers.
>
> Signed-off-by: John Ferlan <jferlan(a)redhat.com>
> ---
> src/conf/virsecretobj.c | 53 ++++++++++++++++++++++++----------------------
> src/conf/virsecretobj.h | 3 ++-
> src/secret/secret_driver.c | 14 ++++++++++--
> 3 files changed, 42 insertions(+), 28 deletions(-)
>
Upon further reflection, I'll drop this and rework my later patches...
Eventually there's an object that contains the "def", "newDef",
"active", and "configFile" since those are fairly commonly used.
John