Re: [PATCH] qemu: Add virtio related options to vsock

On 1/27/21 7:46 PM, Boris Fiuczynski wrote: > Add virtio related options iommu, ats and packed as driver element > attributes > to vsock devices. Ex: > >   <vsock model='virtio'> >     <cid auto='no' address='3'/> >     <driver iommu='on'/> >   </vsock> > > Signed-off-by: Boris Fiuczynski <fiuczy(a)linux.ibm.com&gt; > --- >   docs/formatdomain.rst                         |  2 + >   docs/schemas/domaincommon.rng                 |  5 +++ >   src/conf/domain_conf.c                        | 34 +++++++++++++-- >   src/conf/domain_conf.h                        |  1 + >   src/qemu/qemu_command.c                       |  3 ++ >   src/qemu/qemu_validate.c                      |  3 ++ >   .../vhost-vsock-ccw-iommu.s390x-latest.args   | 42 +++++++++++++++++++ >   .../vhost-vsock-ccw-iommu.xml                 | 33 +++++++++++++++ >   tests/qemuxml2argvtest.c                      |  1 + >   .../vhost-vsock-ccw-iommu.s390x-latest.xml    | 37 ++++++++++++++++ >   tests/qemuxml2xmltest.c                       |  2 + >   11 files changed, 160 insertions(+), 3 deletions(-) >   create mode 100644 > tests/qemuxml2argvdata/vhost-vsock-ccw-iommu.s390x-latest.args >   create mode 100644 tests/qemuxml2argvdata/vhost-vsock-ccw-iommu.xml >   create mode 100644 > tests/qemuxml2xmloutdata/vhost-vsock-ccw-iommu.s390x-latest.xml Alright, I've made all the changes as discussed and pushed. Reviewed-by: Michal Privoznik <mprivozn(a)redhat.com&gt; Michal