On Mon, 2018-04-09 at 17:20 +0200, Ján Tomko wrote:
diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c
index 9534eb6fae..ae183a380f 100644
--- a/tests/qemuxml2argvtest.c
+++ b/tests/qemuxml2argvtest.c
@@ -955,8 +955,7 @@ mymain(void)
DO_TEST("disk-drive-cache-v2-none", NONE);
DO_TEST("disk-drive-cache-directsync", NONE);
DO_TEST("disk-drive-cache-unsafe", NONE);
- DO_TEST("disk-drive-copy-on-read",
- QEMU_CAPS_DRIVE_COPY_ON_READ);
+ DO_TEST("disk-drive-copy-on-read", NONE);
DO_TEST("disk-drive-network-nbd", NONE);
DO_TEST("disk-drive-network-nbd-export", NONE);
DO_TEST("disk-drive-network-nbd-ipv6", NONE);
@@ -1042,7 +1041,6 @@ mymain(void)
QEMU_CAPS_VIRTIO_TX_ALG,
QEMU_CAPS_VIRTIO_BLK_SCSI);
DO_TEST("disk-copy_on_read",
- QEMU_CAPS_DRIVE_COPY_ON_READ,
QEMU_CAPS_VIRTIO_TX_ALG,
QEMU_CAPS_VIRTIO_BLK_SCSI);
DO_TEST("disk-drive-discard",
Since this test (disk-copy_on_read) covers the feature, you can
get rid of the other one (disk-drive-copy-on-read).
Reviewed-by: Andrea Bolognani <abologna(a)redhat.com>
--
Andrea Bolognani / Red Hat / Virtualization