Re: [libvirt] [PATCH v2 3/8] blockcopy: expose new API in virsh

On 08/26/14 13:21, Eric Blake wrote: > Expose the new power of virDomainBlockCopy through virsh. Continue > to use the older API where possible, for maximum compatibility. >

> @@ -1901,18 +1935,82 @@ cmdBlockCopy(vshControl *ctl, const vshCmd *cmd) > vshError(ctl, "%s", _("bandwidth must be a number")); > goto cleanup; > } > + if (vshCommandOptUIntWrap(cmd, "granularity", &granularity) < 0) { > + vshError(ctl, "%s", _("granularity must be a number")); > + goto cleanup; > + } I don't think wrapping makes sense here as you've documented that it has to be a power of 2.

> + if (vshCommandOptUIntWrap(cmd, "buf-size", &buf_size) < 0) { > + vshError(ctl, "%s", _("buf-size must be a number")); > + goto cleanup; > + }

ACK, the wrapped granularity number should be rejected by the daemon. Peter