Re: [libvirt] [Qemu-devel] [PATCH 3/7] qapi: add query-machines command

Luiz Capitulino <lcapitulino(a)redhat.com&gt; writes: > On Fri, 10 Aug 2012 09:41:20 -0500 > Anthony Liguori <aliguori(a)us.ibm.com&gt; wrote: > >> Luiz Capitulino <lcapitulino(a)redhat.com&gt; writes: >> >> > On Fri, 27 Jul 2012 08:37:15 -0500 >> > Anthony Liguori <aliguori(a)us.ibm.com&gt; wrote: >> > >> >> This provides the same output as -M ? but in a structured way. >> >> >> >> Signed-off-by: Anthony Liguori <aliguori(a)us.ibm.com&gt; >> >> --- >> >> qapi-schema.json | 28 ++++++++++++++++++++++++++++ >> >> qmp-commands.hx | 6 ++++++ >> >> vl.c | 31 +++++++++++++++++++++++++++++++ >> >> 3 files changed, 65 insertions(+), 0 deletions(-) >> >> >> >> diff --git a/qapi-schema.json b/qapi-schema.json >> >> index 28e9914..5b47026 100644 >> >> --- a/qapi-schema.json >> >> +++ b/qapi-schema.json >> >> @@ -2200,3 +2200,31 @@ >> >> # Since: 0.14.0 >> >> ## >> >> { 'command': 'closefd', 'data': {'fdname': 'str'} } >> >> + >> >> +## >> >> +# @MachineInfo: >> >> +# >> >> +# Information describing a machine. >> >> +# >> >> +# @name: the name of the machine >> >> +# >> >> +# @alias: #optional an alias for the machine name >> >> +# >> >> +# @default: #optional whether the machine is default >> > >> > Why is default optional? >> >> Brievity. > > Can you elaborate, please? There is only one machine that is default. Having default=false for all of the rest just adds a lot of unnecessary information in the response.