Re: [libvirt PATCH v2 03/17] ch_domain: fix indentation in ch_domain
On 12/3/2021 11:28 AM, Ján Tomko wrote:
On a Thursday in 2021, Praveen K Paladugu wrote:
> Signed-off-by: Praveen K Paladugu <prapal(a)linux.microsoft.com>
> ---
> src/ch/ch_domain.c | 130 ++++++++++++++++++++++-----------------------
> 1 file changed, 64 insertions(+), 66 deletions(-)
>
> diff --git a/src/ch/ch_domain.c b/src/ch/ch_domain.c
> index dd4de9e1ea..44f7d26ca4 100644
> --- a/src/ch/ch_domain.c
> +++ b/src/ch/ch_domain.c
> @@ -30,16 +30,12 @@
>
> static int
> -virCHDomainObjInitJob(virCHDomainObjPrivate *priv)
> +virCHDomainObjInitJob(virCHDomainObjPrivate * priv)
The prevailing style in libvirt codebase is no space after the '*'
Fixed in v3
> {
> memset(&priv->job, 0, sizeof(priv->job));
>
>
[...]
> - if (def->nserials && def->serials[0]->source->type !=
> VIR_DOMAIN_CHR_TYPE_PTY) {
> + if (def->nserials
> + && def->serials[0]->source->type !=
VIR_DOMAIN_CHR_TYPE_PTY) {
> virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
> _("Serial can only be enabled for a PTY"));
> return -1;
80 columns is not a hard limit, there's no need to touch this.
Addressed in v3
Jano
> --
> 2.27.0
>
>
--
Regards,
Praveen K Paladugu