Re: [libvirt] [PATCH v1 10/32] util: socketaddr: use VIR_AUTOPTR for aggregate types

On Sat, Jul 28, 2018 at 11:31:25PM +0530, Sukrit Bhatnagar wrote: > By making use of GNU C's cleanup attribute handled by the > VIR_AUTOPTR macro for declaring aggregate pointer variables, > majority of the calls to *Free functions can be dropped, which > in turn leads to getting rid of most of our cleanup sections. > > Signed-off-by: Sukrit Bhatnagar <skrtbhtngr(a)gmail.com&gt; > --- > src/util/virsocketaddr.c | 38 ++++++++++++++++---------------------- > 1 file changed, 16 insertions(+), 22 deletions(-) > > diff --git a/src/util/virsocketaddr.c b/src/util/virsocketaddr.c > index eee725d..1b195cd 100644 > --- a/src/util/virsocketaddr.c > +++ b/src/util/virsocketaddr.c > @@ -1193,52 +1193,46 @@ virSocketAddrPTRDomain(const virSocketAddr *addr, > unsigned int prefix, > char **ptr) > { > - virBuffer buf = VIR_BUFFER_INITIALIZER; > + VIR_AUTOPTR(virBuffer) buf = NULL; I'll move this one line down. Reviewed-by: Erik Skultety <eskultet(a)redhat.com&gt;