Re: [libvirt] [PATCH 09/10] libxl_migration: Resolve Coverity NULL_RETURNS

> > Hmmm.. right > > Maybe a: > > if (event) { > libxlDomainEventQueue(driver, event); > event = NULL; > } > > before the: > > dom = virGetDomain(dconn, vm->def->name, vm->def->uuid); > Hrm, I wonder if it is even possible for dom to be NULL in this case? We are in the finish phase and have even unpaused the domain, if requested. I see that dom == NULL is never checked in qemuMigrationFinish(). Perhaps the whole 'if (dom == NULL)' check can be removed here too. Regards, Jim