Re: [libvirt] [PATCH 1/2] Introduce virDomainDeviceIterate
On Tue, 2019-05-21 at 16:25 +0200, Ján Tomko wrote:
[...]
@@ -5793,10 +5806,9 @@ virDomainDefPostParse(virDomainDefPtr def,
}
/* iterate the devices */
- ret = virDomainDeviceInfoIterateInternal(def,
- virDomainDefPostParseDeviceIterator,
- DOMAIN_DEVICE_ITERATE_ALL_CONSOLES,
- &data);
+ ret = virDomainDeviceIterate(def,
+ virDomainDefPostParseDeviceIterator,
+ &data);
Since we have no callers of the new function outside of domain_conf,
we can leave it private. Actually, we can do better, by not creating
the function in the first place and simply adding the missing flag
to this single call to virDomainDeviceInfoIterateInternal().
NACK
--
Andrea Bolognani / Red Hat / Virtualization