[libvirt] [PATCH v2 04/14] rpc: Add typedef for the anonymous enum used for authentication methods
Add typedef for the anonymous enum used for the authentication methods
and remove the default case. This allows the usage of the type in a
switch statement and taking advantage of the compilers feature to
detect uncovered cases.
Signed-off-by: Marc Hartmayer <mhartmay(a)linux.vnet.ibm.com>
Reviewed-by: Boris Fiuczynski <fiuczy(a)linux.vnet.ibm.com>
Reviewed-by: Stefan Zimmermann <stzi(a)linux.vnet.ibm.com>
Reviewed-by: John Ferlan <jferlan(a)redhat.com>
---
daemon/remote.c | 4 +---
src/rpc/virnetserverservice.h | 4 ++--
2 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/daemon/remote.c b/daemon/remote.c
index 1df02c1f5042..45cb99a56146 100644
--- a/daemon/remote.c
+++ b/daemon/remote.c
@@ -3279,7 +3279,7 @@ remoteDispatchAuthList(virNetServerPtr server,
if (VIR_ALLOC_N(ret->types.types_val, ret->types.types_len) < 0)
goto cleanup;
- switch (auth) {
+ switch ((virNetServerServiceAuthMethods) auth) {
case VIR_NET_SERVER_SERVICE_AUTH_NONE:
ret->types.types_val[0] = REMOTE_AUTH_NONE;
break;
@@ -3289,8 +3289,6 @@ remoteDispatchAuthList(virNetServerPtr server,
case VIR_NET_SERVER_SERVICE_AUTH_SASL:
ret->types.types_val[0] = REMOTE_AUTH_SASL;
break;
- default:
- ret->types.types_val[0] = REMOTE_AUTH_NONE;
}
rv = 0;
diff --git a/src/rpc/virnetserverservice.h b/src/rpc/virnetserverservice.h
index 9afa0b13dbc6..5d8c583db2e2 100644
--- a/src/rpc/virnetserverservice.h
+++ b/src/rpc/virnetserverservice.h
@@ -27,11 +27,11 @@
# include "virnetserverprogram.h"
# include "virobject.h"
-enum {
+typedef enum {
VIR_NET_SERVER_SERVICE_AUTH_NONE = 0,
VIR_NET_SERVER_SERVICE_AUTH_SASL,
VIR_NET_SERVER_SERVICE_AUTH_POLKIT,
-};
+} virNetServerServiceAuthMethods;
typedef int (*virNetServerServiceDispatchFunc)(virNetServerServicePtr svc,
virNetSocketPtr sock,
--
2.13.4