Re: [libvirt] PATCH: Enable migration with QEMU >= 0.10.0
Daniel P. Berrange schrieb:
On Wed, May 13, 2009 at 10:43:39PM +0200, Gerrit Slomma wrote:
> Daniel P. Berrange schrieb:
>
>> The KVM migration code was added to QEMU for the 0.10.0 release, so we
>> should enable this in libvirt now.
>>
>> Daniel
>>
> Hello
>
> Why is in qemu_conf.c caps initialized with 0 for offlineMigrate and
> liveMigrate?
>
> qemu_conf.c line 364 ff
>
> virCapsPtr qemudCapsInit(void) {
> struct utsname utsname;
> virCapsPtr caps;
> int i;
>
> /* Really, this never fails - look at the man-page. */
> uname (&utsname);
>
> if ((caps = virCapabilitiesNew(utsname.machine,
> 0, 0)) == NULL)
>
> virsh capabilities does not return <migration_features>
> Is this a bug or doesn't it matter and is a mere cosmetical issue?
>
That's a bug. It also doesn't specify the supported URI formats
Daniel
So could this patch for the now be applied?
--- a/src/qemu_conf.c 2009-04-20 11:08:15.000000000 +0200
+++ b/src/qemu_conf.c 2009-05-13 22:28:31.000000000 +0200
@@ -370,7 +370,7 @@
uname (&utsname);
if ((caps = virCapabilitiesNew(utsname.machine,
- 0, 0)) == NULL)
+ 1, 1)) == NULL)
goto no_memory;
/* Using KVM's mac prefix for QEMU too */
would look up for the URI formats too if i have some time to spare.
Gerrit