Re: [libvirt] [PATCH 1/2] util: honor reportError parameter in virSocketAddrParseInternal
On 03/26/2018 04:29 PM, Jim Fehlig wrote:
Signed-off-by: Jim Fehlig <jfehlig(a)suse.com>
---
src/util/virsocketaddr.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: John Ferlan <jferlan(a)redhat.com>
May was well wait for 4.2.0 to be released before pushing...
John
diff --git a/src/util/virsocketaddr.c b/src/util/virsocketaddr.c
index 95b527436..31a740cb8 100644
--- a/src/util/virsocketaddr.c
+++ b/src/util/virsocketaddr.c
@@ -107,7 +107,8 @@ virSocketAddrParseInternal(struct addrinfo **res,
int err;
if (val == NULL) {
- virReportError(VIR_ERR_INVALID_ARG, "%s", _("Missing
address"));
+ if (reportError)
+ virReportError(VIR_ERR_INVALID_ARG, "%s", _("Missing
address"));
return -1;
}