Re: [libvirt] [PATCH v8] add 802.1Qbh and 802.1Qbg handling

On Wednesday 26 May 2010, Stefan Berger wrote: We should never need to tell lldpad the macvtap name, because lldpad should not need to care about the implementation details of macvtap. The problem is that the link may be on anything, including but not limited to - tap on a bridge - raw socket on vhost-net - macvlan - macvtap - sr-iov VF Some of these are not visible to lldpad, or may not have been created yet, or may already be in a different namespace, so it's impossible for lldpad to cover this in general, only the macvtap/macvlan case without namespaces would work reliably. libvirt however does know both the mac address and the vlan id, because it knows what it has created (e.g. macvlan) or configured (e.g. sr-iov). patch attached. Ok, so we need to fix that as well. In case of enic VFs, we also need to pass the physical device, so the information should be there somewhere in libvirt. Passing the macvtap device won't work because of the reasons mentioned above. This is independent of Qbg but depends on whether we're talking to the kernel or to a user application like lldpad. The VF number does not have a meaning to lldpad, so we can define whatever we see fit here. My idea was to always pass VF=0 on a request in the IFLA_VF_VLAN and IFLA_VF_MAC attributes, which unfortunately require putting something in there. lldpad can reject anything that has a nonzero number in there, to let us extend the protocol in the future. Arnd